chore: Put passkeys in a dedicated folder on Android#146
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Android KeyPairManager implementation to store passkey key material in a dedicated filesDir/passkeys directory (instead of directly under filesDir), and adds a one-time migration that moves existing *.key files into that folder.
Changes:
- Introduce a lazily-created
keysDir(filesDir/passkeys) and migrate legacy*.keyfiles into it on first access. - Update key generation, retrieval, listing, lookup, and deletion to operate on
keysDir. - Replace the previous “save file” helper with a
keyFile(...)path helper that centralizes the new naming/location.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
LouisCAD
force-pushed
the
put-passkeys-into-a-dedicated-folder-on-android
branch
from
2dd7e6c to
e123c0d
Compare
tevincent
approved these changes
Apr 30, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.