Conversation
LouisCAD
requested review from
baillyjamy and
Copilot
and removed request for
Copilot
|
There was a problem hiding this comment.
Pull request overview
This PR updates the library’s issue/error modeling by renaming Issue.Retriable.Reason to Cause, and extends the ReLogin migration flow to allow dismissing the last displayed issue while still waiting for credentials.
Changes:
- Renamed
Issue.Retriable.ReasontoIssue.Retriable.Causeand updated call sites. - Added a dismissable ReLogin issue model (
ReLogin.DismissableIssue) and integrated dismissal handling during credential entry. - Updated
NetworkExceptionto carry an underlyingcause, and adjustedApiClientProvideraccordingly.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| multiplatform-lib/src/commonMain/kotlin/network/exceptions/NetworkException.kt | Changes NetworkException constructor to include a cause. |
| multiplatform-lib/src/commonMain/kotlin/internal/network/ApiClientProvider.kt | Passes underlying IOException as NetworkException cause; uses named args for UnexpectedApiErrorFormatException. |
| multiplatform-lib/src/commonMain/kotlin/internal/AuthenticatorFacadeImpl.kt | Implements ReLogin issue dismissal while awaiting credentials; updates issue mapping to Cause. |
| multiplatform-lib/src/commonMain/kotlin/Issue.kt | Renames Retriable.Reason to Retriable.Cause. |
| multiplatform-lib/src/commonMain/kotlin/Account.kt | Introduces ReLogin.DismissableIssue and renames LoginFailed(cause) to LoginFailed(issue). |
| app/src/main/kotlin/com/infomaniak/auth/ui/screen/accountdetails/ActionRequiredCard.kt | Updates UI handling for LoginFailed(issue) and Issue.Retriable.Cause. |
| app/src/main/kotlin/com/infomaniak/auth/ui/previewparameter/AccountPreviewParameter.kt | Updates preview data to the new ReLogin issue model and Cause. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
baillyjamy
approved these changes
Apr 30, 2026
LouisCAD
deleted the
rename-reason-to-cause-and-add-relogin-issue-dismissal
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.