Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce main-thread blocking by deferring HttpClient creation and moving it onto an IO dispatcher, then plumbing the needed coroutine scope through the library’s facade.
Changes:
- Refactor
ApiClientProviderto lazily create the KtorHttpClientvia a deferred running onDispatchers.IO. - Update
AuthenticatorRequestto accept anHttpClientprovider (suspend () -> HttpClient) and invoke it per request. - Pass a
CoroutineScopefromAuthenticatorFacadeintoApiClientProvider, and eagerly initializeAppSettingsDatabaseinMainApplicationas a StrictMode workaround.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| multiplatform-lib/src/commonMain/kotlin/internal/requests/AuthenticatorRequest.kt | Switches from a concrete HttpClient to a suspend provider and updates request calls accordingly. |
| multiplatform-lib/src/commonMain/kotlin/internal/network/ApiClientProvider.kt | Introduces lazy async HttpClient creation on Dispatchers.IO and exposes it as a suspend provider. |
| multiplatform-lib/src/commonMain/kotlin/AuthenticatorFacade.kt | Wires a CoroutineScope into ApiClientProvider construction. |
| app/src/main/kotlin/com/infomaniak/auth/MainApplication.kt | Adds an injected AppSettingsDatabase field to force eager DB initialization prior to enabling StrictMode. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tevincent
approved these changes
Apr 30, 2026
1b2a124 to
8ecec02
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



No description provided.