Conversation
…wift namespacing limitation
|
There was a problem hiding this comment.
Pull request overview
This PR renames several migration/user-profile related models in the shared KMP library to use a Shared* prefix, addressing Swift/Kotlin-Native namespacing limitations and aligning the Android app + internal library code with the new names.
Changes:
- Renamed shared migration models (e.g.,
ApiToken→SharedApiToken,UserProfile→SharedUserProfile,Security→SharedSecurity, etc.). - Updated internal multiplatform-lib request/manager code to use the renamed models.
- Updated Android app integration code (
MigrationUtils, DI bridge) to match the new types.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| multiplatform-lib/src/commonMain/kotlin/network/interfaces/AuthenticatorBridge.kt | Updates bridge API surface to use SharedApiToken / SharedUserProfile. |
| multiplatform-lib/src/commonMain/kotlin/models/migration/SharedApiToken.kt | Renames the migration token model to SharedApiToken. |
| multiplatform-lib/src/commonMain/kotlin/models/migration/user/SharedUserProfile.kt | Renames the migration user profile model to SharedUserProfile and updates embedded token type. |
| multiplatform-lib/src/commonMain/kotlin/models/migration/user/preferences/Preferences.kt | Switches preference fields to the renamed Shared* preference/security models. |
| multiplatform-lib/src/commonMain/kotlin/models/migration/user/preferences/SharedPreferenceTemplate.kt | Renames preference base type to SharedPreferenceTemplate. |
| multiplatform-lib/src/commonMain/kotlin/models/migration/user/preferences/SharedCountry.kt | Renames Country to SharedCountry and updates base class. |
| multiplatform-lib/src/commonMain/kotlin/models/migration/user/preferences/SharedLanguage.kt | Renames Language to SharedLanguage and updates base class. |
| multiplatform-lib/src/commonMain/kotlin/models/migration/user/preferences/SharedOrganizationPreference.kt | Renames OrganizationPreference to SharedOrganizationPreference. |
| multiplatform-lib/src/commonMain/kotlin/models/migration/user/preferences/SharedTimeZone.kt | Renames TimeZone to SharedTimeZone and updates base class. |
| multiplatform-lib/src/commonMain/kotlin/models/migration/user/preferences/security/SharedSecurity.kt | Renames Security to SharedSecurity and updates auth-devices element type. |
| multiplatform-lib/src/commonMain/kotlin/models/migration/user/preferences/security/SharedAuthDevices.kt | Renames AuthDevices to SharedAuthDevices. |
| multiplatform-lib/src/commonMain/kotlin/internal/requests/AuthenticatorRequest.kt | Updates user-profile API response typing to SharedUserProfile. |
| multiplatform-lib/src/commonMain/kotlin/internal/managers/MigrationManager.kt | Updates migration flow to pass/construct SharedApiToken. |
| multiplatform-lib/src/commonMain/kotlin/internal/managers/AuthenticatorManager.kt | Updates authentication result typing/construction to SharedApiToken. |
| multiplatform-lib/src/commonMain/kotlin/internal/MigrationAuthentication.kt | Updates sealed authentication model to carry SharedApiToken. |
| app/src/main/kotlin/com/infomaniak/auth/utils/MigrationUtils.kt | Updates mapping utilities to accept/convert the renamed shared models. |
| app/src/main/kotlin/com/infomaniak/auth/di/ApplicationModule.kt | Updates DI bridge implementation to accept SharedUserProfile and use SharedApiToken aliasing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



No description provided.