Merged
Conversation
It needs to happen before dagger initializes AccountUtils which will read its content.
|
There was a problem hiding this comment.
Pull request overview
This PR fixes notification registration wiring for the standard flavor by ensuring notification-related components are initialized/registered early enough during app startup and by adding the required flavor-specific manifest entries.
Changes:
- Initialize
userDataCleanableListinMainApplication’sinitblock (instead ofonCreate) so it’s available earlier in app lifecycle. - For the
standardflavor, extenduserDataCleanableListwithNotificationsRegistrationManagerinStandardMainApplication’sinitblock. - Add a
standard-source-setAndroidManifest.xmlto register the flavor-specificAuthenticatorMessagingServiceand override the Application class.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/src/standard/kotlin/com/infomaniak/auth/StandardMainApplication.kt | Moves NotificationsRegistrationManager registration to app init time for the standard flavor. |
| app/src/standard/AndroidManifest.xml | Adds standard-flavor manifest overlay to register the FCM messaging service and set the flavor Application class. |
| app/src/main/kotlin/com/infomaniak/auth/MainApplication.kt | Initializes userDataCleanableList earlier (in init) to ensure it’s available before DI consumers may access it. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tevincent
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.