Skip to content

chore: Fix notifications registration#156

Merged
LouisCAD merged 2 commits intomainfrom
fix-notifications-registration
May 1, 2026
Merged

chore: Fix notifications registration#156
LouisCAD merged 2 commits intomainfrom
fix-notifications-registration

Conversation

@LouisCAD
Copy link
Copy Markdown
Contributor

No description provided.

It needs to happen before dagger initializes AccountUtils
which will read its content.
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 30, 2026

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes notification registration wiring for the standard flavor by ensuring notification-related components are initialized/registered early enough during app startup and by adding the required flavor-specific manifest entries.

Changes:

  • Initialize userDataCleanableList in MainApplication’s init block (instead of onCreate) so it’s available earlier in app lifecycle.
  • For the standard flavor, extend userDataCleanableList with NotificationsRegistrationManager in StandardMainApplication’s init block.
  • Add a standard-source-set AndroidManifest.xml to register the flavor-specific AuthenticatorMessagingService and override the Application class.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
app/src/standard/kotlin/com/infomaniak/auth/StandardMainApplication.kt Moves NotificationsRegistrationManager registration to app init time for the standard flavor.
app/src/standard/AndroidManifest.xml Adds standard-flavor manifest overlay to register the FCM messaging service and set the flavor Application class.
app/src/main/kotlin/com/infomaniak/auth/MainApplication.kt Initializes userDataCleanableList earlier (in init) to ensure it’s available before DI consumers may access it.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@LouisCAD LouisCAD merged commit f32c52d into main May 1, 2026
14 checks passed
@LouisCAD LouisCAD deleted the fix-notifications-registration branch May 1, 2026 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants