feat: Display up to 5 matching contacts during search by elouanbtx · Pull Request #2863 · Infomaniak/android-kMail

elouanbtx · 2026-04-14T12:11:55Z

Expected behavior:
While the user has not pressed Enter or selected a filter, display a maximum of 5 contacts matching the search query.
When a contact is clicked, the search input is automatically populated with that contact's email address (<contact.email>).

github-actions · 2026-04-14T12:37:05Z

Failed to generate code suggestions for PR

github-actions · 2026-04-14T13:24:48Z

PR Reviewer Guide 🔍

(Review updated until commit `239353b`)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

github-actions · 2026-04-14T13:37:00Z

Failed to generate code suggestions for PR

github-actions · 2026-04-16T09:28:27Z

Persistent review updated to latest commit 5fabd6a

github-actions · 2026-04-16T09:38:55Z

Failed to generate code suggestions for PR

github-actions · 2026-04-16T10:59:46Z

Persistent review updated to latest commit 3509caa

github-actions · 2026-04-16T11:22:20Z

Persistent review updated to latest commit 01d14c1

github-actions · 2026-04-16T12:36:21Z

Failed to generate code suggestions for PR

github-actions · 2026-04-17T07:46:35Z

Persistent review updated to latest commit 1e00265

github-actions · 2026-04-17T07:58:47Z

Failed to generate code suggestions for PR

github-actions · 2026-04-20T09:05:57Z

Persistent review updated to latest commit ef31a79

github-actions · 2026-04-20T09:18:14Z

Failed to generate code suggestions for PR

github-actions · 2026-04-20T14:52:35Z

Failed to generate code suggestions for PR

github-actions · 2026-04-21T06:19:29Z

Persistent review updated to latest commit 715fdce

github-actions · 2026-04-21T06:31:41Z

Failed to generate code suggestions for PR

github-actions · 2026-04-21T14:38:39Z

Persistent review updated to latest commit 239353b

github-actions · 2026-04-21T14:50:54Z

Failed to generate code suggestions for PR

…ked again

…on containing unnecessary elements for this use case

… improve bottom margin handling for the last contact

…hing folders, and searching again

sonarqubecloud · 2026-04-24T14:25:13Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

FabianDevel · 2026-05-01T07:55:45Z

+    fun searchMergedContacts(searchQuery: String, searchQueryClean: String, limit: Int = 5): List<MergedContact> {
+        val queryStr = if (searchQuery != searchQueryClean) {
+            "(name CONTAINS[c] $0 OR email CONTAINS[c] $0) OR (name CONTAINS[c] $1 OR email CONTAINS[c] $1)"
+        } else {
+            "name CONTAINS[c] $0 OR email CONTAINS[c] $0"
+        }
+        return userInfoRealm.query<MergedContact>(queryStr, searchQuery, searchQueryClean)
+            .sort(MergedContact::name.name)
+            .sort(MergedContact::comesFromApi.name, Sort.DESCENDING)
+            .limit(limit)
+            .find()
+    }


You should divide this in two function, a private "-query" one, and a public one that call the query, like this others

You should also use findSuspend instead of find

FabianDevel · 2026-05-01T08:37:47Z

+        if (!isOnlyRightShown()) {
+            searchViewModel.clearSearchState()
+        }


Suggested change

if (!isOnlyRightShown()) {

searchViewModel.clearSearchState()

}

if (!isOnlyRightShown()) searchViewModel.clearSearchState()

FabianDevel · 2026-05-01T08:38:50Z

+                    binding.searchBar.searchTextInput.setText(emailWithQuotes)
+                    binding.searchBar.searchTextInput.setSelection(emailWithQuotes.length)


Use an apply here to avoid repeating the searchInput stuff

FabianDevel · 2026-05-01T08:45:13Z

+    val allSearchResults = combine(
+        contactsResults,
+        threadsSearchResults,
+    ) { contacts, threads ->


Suggested change

val allSearchResults = combine(

contactsResults,

threadsSearchResults,

) { contacts, threads ->

val allSearchResults = combine(contactsResults, threadsSearchResults ) { contacts, threads ->

FabianDevel · 2026-05-01T09:20:11Z

    var currentSearchQuery: String = ""
        private set

+    val uiState = MutableLiveData<SearchUiState>(SearchUiState.IDLE)


This variable isn't read, so it's useless

FabianDevel · 2026-05-01T11:23:05Z

+                val contactsList = mergedContactController.searchMergedContacts(query, queryClean)
+                contactsList


Th evariable here is not very useful

FabianDevel · 2026-05-01T11:25:21Z


            computeSearchFilters(folder, filters, query)?.let { newFilters ->
-                fetchThreads(folder, newFilters, query, shouldGetNextPage)
+                fetchThreads(folder, newFilters, query, shouldGetNextPage, contacts.isNotEmpty())


Put the argument name for all boolean that aren't already named the same

FabianDevel · 2026-05-01T11:28:32Z

        newFilters: Set<ThreadFilter>,
        query: String,
        shouldGetNextPage: Boolean,
+        hasContacts: Boolean = false,


This default value is useless as the function is only use once
Furthermore, I think we want to enforce passing an argument here to avoid forgetting that case

FabianDevel · 2026-05-01T11:29:00Z

        threadController.saveSearchThreads(searchThreads)
    }

+    enum class SearchUiState {


Suggested change

enum class SearchUiState {

private enum class SearchUiState {

FabianDevel · 2026-05-01T11:40:46Z

+        }
+    }
+
+    fun removeBackground(){


Suggested change

fun removeBackground(){

fun removeBackground() {

github-actions Bot assigned elouanbtx Apr 14, 2026

github-actions Bot added the Review effort 3/5 label Apr 14, 2026

Elouan1411 force-pushed the contact-search branch from c67044e to 5fabd6a Compare April 16, 2026 09:21

github-actions Bot reviewed Apr 16, 2026

View reviewed changes

Comment thread app/src/main/java/com/infomaniak/mail/ui/main/search/SearchFragment.kt Outdated

Comment thread app/src/main/java/com/infomaniak/mail/ui/main/search/SearchViewModel.kt

github-actions Bot reviewed Apr 16, 2026

View reviewed changes

Comment thread app/src/main/java/com/infomaniak/mail/ui/main/search/SearchFragment.kt Outdated

Comment thread app/src/main/java/com/infomaniak/mail/ui/main/folder/ThreadListAdapter.kt

Comment thread app/src/main/java/com/infomaniak/mail/ui/main/folder/ThreadListAdapter.kt Outdated

solrubado requested changes Apr 16, 2026

View reviewed changes

github-actions Bot reviewed Apr 17, 2026

View reviewed changes

Comment thread app/src/main/java/com/infomaniak/mail/ui/main/search/SearchViewModel.kt

Comment thread app/src/main/java/com/infomaniak/mail/data/cache/userInfo/MergedContactController.kt Outdated

Comment thread app/src/main/java/com/infomaniak/mail/ui/main/search/SearchFragment.kt Outdated

Elouan1411 force-pushed the contact-search branch from 715fdce to 239353b Compare April 21, 2026 14:36

Elouan1411 enabled auto-merge April 24, 2026 13:22

Elouan1411 force-pushed the contact-search branch from a96a499 to 239353b Compare April 24, 2026 14:06

Elouan1411 added 3 commits April 24, 2026 16:18

feat: Add function to get list of contact with query and limit

33f1f4c

feat: Display contacts on search and handle click actions

5659f2f

fix: Clear previous contact search results when search button is clic…

1ce3d37

…ked again

Elouan1411 and others added 18 commits April 24, 2026 16:18

feat: Clear contacts when a filter is selected

a1fbe76

feat: Clear contacts when Enter key is pressed

c29dcd2

feat: Add custom item_contact_search to replace existing implementati…

dee0f8d

…on containing unnecessary elements for this use case

fix: Reimplement contact display logic to properly show or hide contacts

b6eaeef

fix: Display contacts even when no threads are present in results and…

f44adef

… improve bottom margin handling for the last contact

feat: Add rounded ripple effect matching thread style

4b1de5c

fix: Clean code

3298174

fix: Prevent contacts from displaying when performing a search, switc…

bbfbd93

…hing folders, and searching again

fix: Resolve LiveData race condition in state checking

66dd343

refactor: Clean code

b782edd

fix: Add missing element from commit 01d14c1

1092a79

fix: Prevent dataset overwrite

26f4a63

refactor: Clean code

c6b7508

refactor: Use DateSeparator in contact header and rename it

61a487f

fix: Combine contacts and thread results for search

a89962a

fix: Update query in realm to support diacritic

014e323

fix: Move formatSearchList in viewmodel

5e76073

fix: Reduce method length

bbee23e

Elouan1411 force-pushed the contact-search branch from 239353b to bbee23e Compare April 24, 2026 14:20

FabianDevel requested changes May 1, 2026

View reviewed changes

		binding.searchBar.searchTextInput.setText(emailWithQuotes)
		binding.searchBar.searchTextInput.setSelection(emailWithQuotes.length)

		val contactsList = mergedContactController.searchMergedContacts(query, queryClean)
		contactsList

	enum class SearchUiState {
	private enum class SearchUiState {

Conversation

elouanbtx commented Apr 14, 2026

Uh oh!

github-actions Bot commented Apr 14, 2026

Uh oh!

github-actions Bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Reviewer Guide 🔍

(Review updated until commit 239353b)

Uh oh!

github-actions Bot commented Apr 14, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 17, 2026

Uh oh!

github-actions Bot commented Apr 17, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 20, 2026

Uh oh!

github-actions Bot commented Apr 20, 2026

Uh oh!

github-actions Bot commented Apr 20, 2026

Uh oh!

github-actions Bot commented Apr 21, 2026

Uh oh!

github-actions Bot commented Apr 21, 2026

Uh oh!

github-actions Bot commented Apr 21, 2026

Uh oh!

github-actions Bot commented Apr 21, 2026

Uh oh!

sonarqubecloud Bot commented Apr 24, 2026

Quality Gate passed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

github-actions Bot commented Apr 14, 2026 •

edited

Loading

(Review updated until commit `239353b`)