fix: Fix network check race condition#2888
Merged
FabianDevel merged 2 commits intomainfrom Apr 29, 2026
Merged
Conversation
In some cases, the hasNetwork property was read on isNetworkAvailable emission before it was set. It was also much more likely to happen since the flow was activated twice. Now it's shared, and we read the value from a single place.
There was a problem hiding this comment.
Pull request overview
Fixes a race where hasNetwork could be read before being updated from the isNetworkAvailable flow by turning network availability into a single shared StateFlow source of truth in MainViewModel.
Changes:
- Convert
isNetworkAvailableinto aStateFlowviastateIn(...)to ensure one shared upstream collection. - Replace the mutable
hasNetworkfield with a value derived directly fromisNetworkAvailable.value.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
FabianDevel
approved these changes
Apr 29, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, the hasNetwork property was read on isNetworkAvailable emission before it was set.
It was also much more likely to happen since the flow was activated twice. Now it's shared, and we read the value from a single place.