Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
There was a problem hiding this comment.
Pull request overview
This PR updates onboarding/settings copy to support both Face ID and Touch ID (biometry) via format placeholders, and adds a Touch ID illustration asset.
Changes:
- Replaced Face ID–specific localization keys with biometry-based keys using
%@placeholders across supported locales. - Added Touch ID illustration assets (light/dark SVG) to the asset catalog.
- Updated onboarding and settings UI to choose the appropriate biometry slide/label.
Reviewed changes
Copilot reviewed 18 out of 20 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| AuthenticatorResources/Localizable/sv.lproj/Localizable.strings | Replace Face ID onboarding/unlock strings with biometry placeholder keys |
| AuthenticatorResources/Localizable/pt.lproj/Localizable.strings | Replace Face ID onboarding/unlock strings with biometry placeholder keys |
| AuthenticatorResources/Localizable/pl.lproj/Localizable.strings | Replace Face ID onboarding/unlock strings with biometry placeholder keys |
| AuthenticatorResources/Localizable/nl.lproj/Localizable.strings | Replace Face ID onboarding/unlock strings with biometry placeholder keys |
| AuthenticatorResources/Localizable/nb.lproj/Localizable.strings | Replace Face ID onboarding/unlock strings with biometry placeholder keys |
| AuthenticatorResources/Localizable/it.lproj/Localizable.strings | Replace Face ID onboarding/unlock strings with biometry placeholder keys |
| AuthenticatorResources/Localizable/fr.lproj/Localizable.strings | Replace Face ID onboarding/unlock strings with biometry placeholder keys |
| AuthenticatorResources/Localizable/fi.lproj/Localizable.strings | Replace Face ID onboarding/unlock strings with biometry placeholder keys |
| AuthenticatorResources/Localizable/es.lproj/Localizable.strings | Replace Face ID onboarding/unlock strings with biometry placeholder keys |
| AuthenticatorResources/Localizable/en.lproj/Localizable.strings | Replace Face ID onboarding/unlock strings with biometry placeholder keys |
| AuthenticatorResources/Localizable/el.lproj/Localizable.strings | Replace Face ID onboarding/unlock strings with biometry placeholder keys |
| AuthenticatorResources/Localizable/de.lproj/Localizable.strings | Replace Face ID onboarding/unlock strings with biometry placeholder keys |
| AuthenticatorResources/Localizable/da.lproj/Localizable.strings | Replace Face ID onboarding/unlock strings with biometry placeholder keys |
| AuthenticatorResources/Images.xcassets/Illustrations/touch-id.imageset/touch-id-light.svg | Add Touch ID light SVG illustration |
| AuthenticatorResources/Images.xcassets/Illustrations/touch-id.imageset/touch-id-dark.svg | Add Touch ID dark SVG illustration |
| AuthenticatorResources/Images.xcassets/Illustrations/touch-id.imageset/Contents.json | Register Touch ID SVGs in the asset catalog |
| AuthenticatorFeatures/SettingsView/ToggleAppLockSettingsView.swift | Update app-lock toggle label to use biometry placeholder formatting |
| AuthenticatorFeatures/OnboardingView/OnboardingTextBottomView.swift | Make init(title:description:) accessible for formatted strings |
| AuthenticatorFeatures/OnboardingView/OnboardingSlides.swift | Select Face ID vs Touch ID slide and use formatted biometry strings |
| AuthenticatorCore/Constants.swift | Add a helper LAContext factory for determining biometry type |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Failed to generate code suggestions for PR |
lebojo
force-pushed
the
fix/onboarding-touch-id
branch
3 times, most recently
from
f365d2b to
3e6365c
Compare
|
Failed to generate code suggestions for PR |
| return .onboardingSuccessSlide | ||
| case .biometry: | ||
| return .onboardingFaceIdSlide | ||
| return Constants.biometryContext.biometryType == .faceID ? .onboardingFaceIdSlide : .onboardingTouchIdSlide |
Member
There was a problem hiding this comment.
Maybe we should handle the case where it's neither Face ID nor Touch ID
Member
Author
There was a problem hiding this comment.
Actually, it will display the Touch ID icon, but the sentence will be correct.
I thought the Touch ID icon was somewhat universal for "biometry" stuff.
lebojo
force-pushed
the
fix/onboarding-touch-id
branch
from
3e6365c to
a7f990e
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix the strings for biometry instead of faceID in the app