Open
Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce “discard notifications” scenarios by tightening the notifications enablement flow: it adds animated UI feedback in Settings when notifications are enabled but not authorized, and removes the ability to skip the notifications permission step during onboarding.
Changes:
- Animate the visibility of the notifications-authorization warning header in SettingsView.
- Remove the “Later” action from the Onboarding notifications step, leaving only the authorization CTA.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| AuthenticatorFeatures/SettingsView/SettingsView.swift | Adds opacity transition + animation tied to the notifications enabled toggle to animate the authorization warning header. |
| AuthenticatorFeatures/OnboardingView/OnboardingView.swift | Removes the “Later” button from the notifications onboarding step, forcing users through the authorization CTA path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
89
to
93
| .authListStyle() | ||
| .navigationTitle(AuthenticatorResourcesStrings.settingsTitle) | ||
| .sceneLifecycle(willEnterForeground: willEnterForeground) | ||
| .animation(.default, value: isNotificationsEnabled) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an edge case where users skipping the notification modal during migration were permanently unable to re-enable notifications.
Previously, if a user selected "Skip" during the migration flow, the notification modal would never appear again, and there was no option to activate notifications later in the Settings. This update forces the modal to display, ensuring that even if the user declines, they retain the ability to enable notifications via the Settings menu at a later time.