chore: Add missing DownloadQuotaExceededException to finishUploadSession @Throws#292
Merged
valentinperignon merged 2 commits intomainfrom May 1, 2026
Merged
Conversation
Copilot created this pull request from a session on behalf of
valentinperignon
May 1, 2026 04:39
View session
Agent-Logs-Url: https://github.com/Infomaniak/multiplatform-SwissTransfer/sessions/17dcb077-ef5e-4220-aec3-9ef12e30d02b Co-authored-by: valentinperignon <25110022+valentinperignon@users.noreply.github.com>
valentinperignon
force-pushed
the
copilot/add-throws-annotations-to-uploadmanager
branch
from
6838830 to
3e4d644
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds DownloadQuotaExceededException to UploadManager.finishUploadSession()’s @Throws and KDoc so Kotlin/Native (Swift) exception bridging is complete when this exception propagates through TransferManagerUtils.addTransferByLinkUUID.
Changes:
- Added
DownloadQuotaExceededException::classto@ThrowsforfinishUploadSession(). - Added corresponding
@throws DownloadQuotaExceededExceptionKDoc entry. - Added the required import in
UploadManager.kt.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
valentinperignon
changed the title
valentinperignon
changed the title
LunarX
approved these changes
May 1, 2026
valentinperignon
deleted the
copilot/add-throws-annotations-to-uploadmanager
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
finishUploadSession()was missingDownloadQuotaExceededExceptionfrom its@Throwsdeclaration, causing incomplete Swift interop exception bridging.Root cause
finishUploadSession()calls theTransferManager.addTransferByLinkUUID()extension inTransferManagerUtils.kt, which wraps the inner call inrunCatchingand selectively handles onlyFetchTransferExceptionsubclasses — everything else is re-thrown.DownloadQuotaExceededExceptionextendsExceptiondirectly (notFetchTransferException), so it escapes and propagates to the caller.Changes
UploadManager.ktDownloadQuotaExceededException::classto@ThrowsonfinishUploadSession()@throwsKDoc tag@Throws( ... DownloadQuotaExceededException::class, // added — not a FetchTransferException, propagates through TransferManagerUtils ) suspend fun finishUploadSession(uuid: String): String