Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project to target Android SDK 34+ by bumping compileSdk/targetSdk, adding new foreground‐service permissions, and introducing an audio‐specific background service.
- Upgrade
compileSdk/targetSdkin both modules. - Expand driver permission sets to include
FOREGROUND_SERVICE_LOCATIONandFOREGROUND_SERVICE_MICROPHONEon API 34+. - Add an
BackgroundCaptureServiceAudiosubclass and update manifest entries for separate audio vs. location services.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| aprs-android/build.gradle.kts | Bumped compileSdk from 33 to 34. |
| android-application/build.gradle.kts | Bumped compileSdk/targetSdk from 34 to 35. |
| TncDriver.kt / InternetDriver.kt / AfskDriver.kt | Added API 34+ branches for new foreground service permissions in receivePermissions and transmitPermissions. |
| AndroidSymbolFactory.kt | Added null‐safe fallback for Bitmap.Config. |
| BackgroundCaptureService.kt / CaptureActivity.kt | Made BackgroundCaptureService open, added BackgroundCaptureServiceAudio, and wired audio vs. default service intents. |
| android-application/src/main/AndroidManifest.xml | Added new permissions and split the background service into two entries for audio vs. location. |
Comments suppressed due to low confidence (1)
android-application/src/main/java/com/inkapplications/ack/android/capture/service/BackgroundCaptureService.kt:55
- [nitpick] The subclass
BackgroundCaptureServiceAudioname doesn't match the manifest entryBackgroundCaptureServiceAfsk. Consider renaming toBackgroundCaptureServiceAfskfor consistency.
class BackgroundCaptureServiceAudio: BackgroundCaptureService()
ReneeVandervelde
force-pushed
the
api-updates
branch
from
75ebb19 to
755d363
Compare
ReneeVandervelde
force-pushed
the
api-updates
branch
from
755d363 to
932094c
Compare
It seems we need background permissions for the foreground service to run on newer versions, even when the app itself is still in the foreground. Would like a more elegant solution and dialog here, but this gets the point across for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to a more recent sdk version for Android
This should fix the crash in #96