[FIX] Do not charge baseline trials against the optimization n_trials budget (+ test)#21
Open
VincentG1234 wants to merge 1 commit into
Open
[FIX] Do not charge baseline trials against the optimization n_trials budget (+ test)#21VincentG1234 wants to merge 1 commit into
n_trials budget (+ test)#21VincentG1234 wants to merge 1 commit into
Conversation
Signed-off-by: Vincent Gimenes <vincent.gimenes@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Baseline runs should not consume the configured optimization trial budget (
n_trials). The synchronous path in_run_baseline_trialsstill incrementedcompleted_trials, which caused the study to stop early (e.g. an incomplete grid). This now matches_collect_completed_trials, which already counts onlyoptimizationtrials.Changes
auto_tune_vllm/core/study_controller.pycompleted_trials += 1after each baseline finishes (success, failure, timeout, exception).n_trialsapplies to optimization trials only.tests/core/test_study_controller.py(generic module for futureStudyControllertests)concurrency_levels→completed_trialsstays0after_run_baseline_trials.Expected behavior after merge
n_trials(and grid cardinality in grid mode) without manually adding+1/+kfor baselines.concurrency_levelsstill mean multiple baseline Optuna trials, but they do not eat the optimization budget.How to test
pytest tests/core/test_study_controller.py