Bug/fix pattern encoding for SIRENE search#288
Merged
Conversation
tfardet
requested changes
Dec 11, 2025
Collaborator
tfardet
left a comment
tfardet
left a comment
There was a problem hiding this comment.
Thanks for the hard work, I have a different understanding for the "ponctuation+blanc*" rule: from their example, the punctuation on its own is not a separator (maybe the * symbol in the name is misleading for regex users): "a.b." should stay "a.b" as a single word.
Co-authored-by: tfardet <79037344+tfardet@users.noreply.github.com>
Co-authored-by: tfardet <79037344+tfardet@users.noreply.github.com>
Collaborator
Author
|
You're right I missed the footnote... That's quite an unfortunate way to use a star in that context...! |
tfardet
approved these changes
Dec 15, 2025
Collaborator
|
No worries, thanks for taking the time to fix that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #286
Can anybody have a second look on the documentation's separators behaviour and my implementation of it ?
In particular concerning the
espace ponctuation+blanc*rule which I understood as "whitespace separator" and "[ponctuation] plus any number of whitespace" (kind of a regex pattern with that*character) which doesn't make much sense (should be resumed to "whitespace OR punctuation" right ?Note : I extracted the html table and parsed it, there should'nt be any typo in the SEPARATOR constant (I only dropped the
espace ponctuation+blanc*rule).