RXR-3044: remove ... from get_map_estimates()#57
Draft
mccarthy-m-g wants to merge 3 commits intomasterfrom
Draft
RXR-3044: remove ... from get_map_estimates()#57mccarthy-m-g wants to merge 3 commits intomasterfrom
... from get_map_estimates()#57mccarthy-m-g wants to merge 3 commits intomasterfrom
Conversation
jasmineirx
approved these changes
Mar 18, 2026
Contributor
jasmineirx
left a comment
jasmineirx
left a comment
There was a problem hiding this comment.
lgtm, approach sounds good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow-up to InsightRX/PKPDsim#125 we want to remove
...fromget_map_estimates()as well, since this was passed toPKPDsim::sim().Marking this as a draft right now. Will mark as ready for review after I've pushed PRs for other packages where we call this function with
..., and tested the consequences of this change in other packages that callPKPDmap::get_map_estimates()more generally.