Skip to content

typo #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
QuintusTheFifth wants to merge 2 commits into
base: main
Choose a base branch
from
Open

typo #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2a8e6c
typo
QuintusTheFifth Jul 11, 2022
b14afc3
typo
QuintusTheFifth Jul 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion testing-items/2-access-control.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Access control is the imposing of policy by preventing users from acting beyond

Check if there’s any function that invokes the `selfdestruct` instruction, and if there is, make sure that the function can only be called by the authorized parties only under necessary circumstances

This can be done by searching for all functions with `selfdestruct` or `suicide` opetion in the contract, and check the access control for the function, if unauthorized actors can execute the function, it is vulnerable, for example:
This can be done by searching for all functions with `selfdestruct` or `suicide` option in the contract, and check the access control for the function, if unauthorized actors can execute the function, it is vulnerable, for example:

```solidity
contract Storage {
Expand Down
2 changes: 1 addition & 1 deletion testing-items/5-blockchain-data.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Price oracle can be implemented by fetching the real-time on-chain data from a d

Check that the price data used is not a spot price which can be easily manipulated.

The use of spot price can be found by searching for the use of reserves to calculate the price. This includes the use of the `getAmontOut()` function.
The use of spot price can be found by searching for the use of reserves to calculate the price. This includes the use of the `getAmountOut()` function.

```solidity
function getPrice() external returns (uint256) {
Expand Down