docs(readme): cap Wrapped screenshot via height attribute (GitHub strips style)#162
Conversation
GitHub's markdown sanitizer drops inline `style` attributes (including the `max-height` we set in #161), so the portrait Wrapped capture rendered at its full natural size after the merge — the gallery row ended up even more imbalanced than before the cap. The HTML `height` attribute is in GitHub's allowlist and the browser keeps the aspect ratio when only one dimension is set, so `height="380"` brings the Wrapped tile to roughly the same rendered height as the landscape karaoke-lyrics tile next to it without any CSS.
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughModification cosmétique du README : l'image "WaveFlow Wrapped" adopte des attributs HTML explicites pour contrôler sa hauteur et son alignement au lieu d'une directive de style CSS, affectant uniquement le rendu visuel de la documentation. ChangesMise à jour visuelle du README
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Follow-up to #161.
GitHub's markdown sanitizer drops inline
styleattributes (max-height: 520px; width: auto;from the merged version), so the portrait Wrapped capture rendered at its natural massive size next to the landscape Karaoke-lyrics tile.Switching to the HTML
heightattribute (allowlisted by GitHub) —height="380"— gives the browser one fixed dimension, which it pairs with the natural aspect ratio to bring the Wrapped tile in line with its row partner.Test plan
Summary by CodeRabbit
Notes de version