Implement local version of vdim#82
Open
tanderson92 wants to merge 74 commits into
Open
Conversation
tanderson92
force-pushed
the
local-vdim
branch
from
c9180d7 to
d880f12
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
===========================================
- Coverage 84.00% 67.75% -16.25%
===========================================
Files 25 25
Lines 3952 4274 +322
===========================================
- Hits 3320 2896 -424
- Misses 632 1378 +746 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…for better conditioning
This stabilizes VDIM in the regime when hk is bounded strictly away from zero.
Member
Author
|
This stabilized lvdim is now working for Helmholtz, both low-frequency / overresolved Helmholtz, using asymptotics and Laplace potentials to build the local Helmholtz corrections (hk << 1), and the well-resolved / not-overresolved Helmholtz too (hk = O(1)). Laplace working too but that was never unstable. @maltezfaria |
…pproach for diagnostics
Use the N=2 Maclaurin expansion for J_0, requiring Laplace corrections up to degree `n+4` where `n` is the interpolation order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimental branch/PR to play around and track progress on ideas related to a local version of VDIM, which is given in schematic form below.