You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you so much @ThePoultryMan for all your effort in making this PR - it really means so much to me and it's super exciting that this is becoming an OSS project others contribute too!
Re the failing test:
just_main_func testing using the custom target is intentional, the purpose of that test is to check if building is possible using the custom JSON target spec.
The error is not related to being unable to get std, which is currently the intended behaviour with the custom target as we don't support enough of Rust (namely generics) to support compiling core or std for a custom target in their entirety (thus in all the other tests with don't use a custom target and piggyback off the host target)
just_main_func uses a no_std, no_core environment to get around this the limitation of being unable to use the core or std libraries when compiling for the custom target.
This failure is instead related to a recent change in the JSON spec for rustc target files.
jvm-unknown-unknown.json.template just needs a minor change to fix this - target-pointer-width needs to be changed to the integer 32 rather than the current string "32".
If you could please make this adjustment in the PR then we can merge it and fully support the latest nightly! Thank you so much again for all your effort! :)
Actually, I'll just merge this and then push the manual update to jvm-unknown-unknown.json.template needed to get just_main_func to pass to main (there's also a removal of an enum variant that came out with the latest nightly a few minutes ago, rust-lang/rust#146564, that needs a small change to fix that I'll handle). Thank you SO MUCH again for your amazing work! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Non-Rust
cargo fmtRust Changes
Idents with TyCtxt.*ItemRefwith*ItemId. So we have to get theAssocItemfrom the functionTyCtxt::associated_item, which we can the get theIdentfrom.ImplItemIdandTraitItemId.Breaks
just_main_fntest. I don't know why, but I am looking into it.