Conversation
- Diagram editor in Tools menu (tab + dock) - Node shapes: rectangle, rounded rect, ellipse, diamond - Connections: edge-to-edge bezier with arrowhead, solid/dashed/dotted styles - Resize handles on nodes and images - Undo/redo (snapshot-based QUndoStack) - Grid background + snap toggle - Property panel for node, connection, and image editing - Align tools (left/right/top/bottom/center/distribute) - Copy/paste/duplicate, right-click context menu - Mermaid flowchart import with auto BFS layout - Local and URL image support with caption - Performance: BSP tree index, DeviceCoordinateCache, MinimalViewportUpdate - Keyboard shortcuts (Ctrl+Z/Y/C/V/D/S/A, Delete, Escape) - Full i18n (English + Traditional Chinese) - Add CLAUDE.md project documentation
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| ErrorProne | 1 high |
| Security | 2 medium |
🟢 Metrics 545 complexity · 4 duplication
Metric Results Complexity 545 Duplication 4
TIP This summary will be updated as you push new changes. Give us feedback
- Add diagram_net_utils.py with SSRF prevention: block file/ftp schemes, reject private/loopback/link-local IPs, enforce 20 MB download limit and connection timeout - URL image download now routes through safe_download_image() - Image reload from saved JSON validates file extension allowlist - Add Security section to CLAUDE.md with full checklist
- Remove unused imports: QImage (items), QTransform, QGraphicsItem (scene) - Remove unused signal: zoom_requested (scene) - Add convention: delete all unused code immediately, no dead code allowed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Features
Diagram Editor Core
.diagram.jsonformatMermaid Import
graph TD/LR/RL/BTsyntax and auto-generate diagram[]rect,()rounded,{}diamond,(())ellipse-->solid,-.->dashed,==>thick-->|label|and-- label -->A --> B --> CImage Support
Performance
i18n
Files changed
pybreeze/pybreeze_ui/diagram_editor/): 8 files, ~3100 linestools_menu.py,extend_english.py,extend_traditional_chinese.pyCLAUDE.mdTest plan