Skip to content

Fix BlockTypes field initialization #3525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NotMyFault merged 1 commit into from
May 15, 2026
Merged

Fix BlockTypes field initialization #3525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions worldedit-core/src/main/java/com/sk89q/worldedit/world/block/BlockTypes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -878,7 +878,7 @@ public final class BlockTypes {
@Nullable
public static final BlockType GOLD_ORE = init();
@Nullable
public static final BlockType GOLDEN_DANDELION = get("minecraft:golden_dandelion");
public static final BlockType GOLDEN_DANDELION = init();
@Nullable
public static final BlockType GRANITE = init();
@Nullable
Expand Down Expand Up @@ -1627,7 +1627,7 @@ public final class BlockTypes {
@Nullable
public static final BlockType POTTED_FLOWERING_AZALEA = init();
@Nullable
public static final BlockType POTTED_GOLDEN_DANDELION = get("minecraft:potted_golden_dandelion");
public static final BlockType POTTED_GOLDEN_DANDELION = init();
@Nullable
public static final BlockType POTTED_JUNGLE_SAPLING = init();
@Nullable
Expand Down Expand Up @@ -2400,7 +2400,7 @@ public final class BlockTypes {
public static final BlockType ZOMBIE_WALL_HEAD = init();

private static Field[] fieldsTmp;
private static int initIndex = 0;
private static int initIndex;

// Init each field
// The order is important
Expand All @@ -2415,6 +2415,10 @@ public static BlockType init() {

// Clears memory after initialization
static {
// we should be at the first non-BlockType field now
if (!fieldsTmp[initIndex].getName().equals("fieldsTmp")) {
throw new IllegalStateException("improper initialization of block type fields");
}
fieldsTmp = null;
}

Expand Down
Loading