Skip to content

Read signing golden fixtures from spec checkout#82

Merged
negillett merged 2 commits into
mainfrom
phase3-sdk-signing-golden
May 30, 2026
Merged

Read signing golden fixtures from spec checkout#82
negillett merged 2 commits into
mainfrom
phase3-sdk-signing-golden

Conversation

@negillett

Copy link
Copy Markdown
Member

Summary

  • Prefer INTENTPROOF_SPEC_DIR/golden/sdk-signing in signing golden tests.
  • Add scripts/check-sdk-signing-fixtures-sync.sh to fail when local mirrors drift from spec.

Phase 3 drift D.9. Requires spec #100 on main for CI green.

Test plan

  • npm test
  • npm run build

Signed-off-by: Nathan Gillett <nathan@intentproof.io>
@cursor

cursor Bot commented May 30, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Test and CI wiring only; no runtime signing or application logic changes.

Overview
Signing golden tests now load fixtures from INTENTPROOF_SPEC_DIR/golden/sdk-signing when that env var is set (as in CI), and still fall back to tests/fixtures locally.

CI checks out intentproof-spec, and if golden/sdk-signing is missing on main, it fetches phase3-ecosystem-conformance so tests can run before spec lands on main. A new scripts/check-sdk-signing-fixtures-sync.sh step fails the build when any mirrored signing_* file under tests/fixtures differs from the spec golden copy.

Reviewed by Cursor Bugbot for commit 07d6c9a. Bugbot is set up for automated code reviews on this repo. Configure here.

Signed-off-by: Nathan Gillett <nathan@intentproof.io>
@negillett negillett merged commit 6ab26b1 into main May 30, 2026
10 checks passed
@negillett negillett deleted the phase3-sdk-signing-golden branch May 30, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant