18 restore option to set tuio connection type during runtime#19
Open
krueger-christian wants to merge 5 commits intomainfrom
Open
18 restore option to set tuio connection type during runtime#19krueger-christian wants to merge 5 commits intomainfrom
krueger-christian wants to merge 5 commits intomainfrom
Conversation
added 5 commits
February 20, 2025 15:43
eqbic
approved these changes
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
TuioInputclass was missing the accessorConnectionType. It has been removed with Commit 367fbccc. However, this accessor was essential for changing the connection type during runtime. This is necessary, for example, if the application switches between connection types that are defined via CLI parameters at app startup.Solution
Restore the removed
ConnectionTypeaccessor, to allow changes of the connection type during runtime (requires also to callTuioInput.Reinit())Further changes
UdpPortaccessor of TuioInput class. The set accessor wrote recursively to itself. This caused a stack overflow when settingUdpPort.