refactor(runner): pass argv through to container without re-quoting#3428
Merged
refactor(runner): pass argv through to container without re-quoting#3428
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the runner container entrypoint flow so commands are forwarded into the container as an argv vector (instead of being re-concatenated and executed via bash -c), enabling callers to pass NAME=value prefixes naturally without re-quoting.
Changes:
- Update
runner/runc.shto pass"$@"through to the container (and adjust help text accordingly). - Update
runner/entrypoint.shto execute the provided argv viaenvso leadingNAME=valuetokens become environment variables for the command.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| runner/runc.sh | Stops concatenating the command into a single string; passes argv through to container and updates usage text/logging. |
| runner/entrypoint.sh | Replaces bash -c "$*" with exec env "$@" to apply leading NAME=value tokens as env vars. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
runc.sh forwards "$@" straight to the container and entrypoint.sh uses
`exec env "$@"` so leading NAME=value tokens become env vars for the
command. Callers no longer need to wrap the whole command in a single
quoted string, e.g.
./runner/runc.sh -- MARKEXPR='dbsync or smash' ./runner/regression.sh
Shell features (pipes, redirections, expansion) are no longer applied
implicitly; wrap with `-- bash -c '...'` when needed.
mkoura
force-pushed
the
runc_pass_arguments
branch
from
3614f27 to
d4f442d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runc.sh forwards "$@" straight to the container and entrypoint.sh uses
exec env "$@"so leading NAME=value tokens become env vars for the command. Callers no longer need to wrap the whole command in a single quoted string, e.g.Shell features (pipes, redirections, expansion) are no longer applied implicitly; wrap with
-- bash -c '...'when needed.