refactor(runner): extract runc.sh helpers into functions#3429
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors runner/runc.sh by extracting several top-level behaviors into dedicated Bash functions to reduce global/script-level state and centralize logic around worktree mounting, .bin validation, and base-image selection.
Changes:
- Extract git worktree
.gitmount detection intoadd_worktree_git_mount. - Extract
.bincompatibility checks intovalidate_bin_dir(now returning non-zero instead ofexiting internally). - Extract container image + mount selection logic into
select_image.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Move .bin validation, worktree .git mount, and base-image selection into dedicated functions with locals, reducing top-level script state.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move .bin validation, worktree .git mount, and base-image selection into dedicated functions with locals, reducing top-level script state.