fix(dbsync_utils): use explicit None check for params#3433
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts protocol-parameter proposal comparison logic in dbsync_utils so that zero-valued parameters are not skipped during validation against db-sync records.
Changes:
- Replace truthy checks with explicit
is Nonechecks when deciding whether to compare a protocol parameter value. - Update db-sync value comparison to allow zero/falsey values to be compared rather than skipped.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Previous truthy check skipped valid zero values when comparing protocol parameter proposals against db-sync records. Use `is None` to only skip missing values.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous truthy check skipped valid zero values when comparing protocol parameter proposals against db-sync records. Use
is Noneto only skip missing values.