chore(makefile): reorganize targets, add VENV support#3435
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Reorganizes the project Makefile into clearer sections and improves developer ergonomics by adding venv-prefixed tooling targets and new maintenance commands.
Changes:
- Add
VENVvariable and use$(VENV)/bin/...forpre-commitandprepare-cluster-scripts - Reorganize targets into Setup / Linting / Documentation / Maintenance sections
- Add
fmt,clean, andclean-alltargets
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mkoura
force-pushed
the
cleanup_makefile
branch
2 times, most recently
from
8a69972 to
fc3201f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mkoura
force-pushed
the
cleanup_makefile
branch
from
fc3201f to
19e35b8
Compare
Group targets into Setup/Linting/Documentation/Maintenance sections. Use $(VENV)/bin/ prefix for pre-commit and prepare-cluster-scripts so targets work without activated venv. Add fmt, clean, clean-all targets.
mkoura
force-pushed
the
cleanup_makefile
branch
from
19e35b8 to
2e2637d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Group targets into Setup/Linting/Documentation/Maintenance sections. Use $(VENV)/bin/ prefix for pre-commit and prepare-cluster-scripts so targets work without activated venv. Add fmt, clean, clean-all targets.