Make Dijkstra genesis config optional#6524
Open
Minhcardanian wants to merge 1 commit intoIntersectMBO:masterfrom
Open
Make Dijkstra genesis config optional#6524Minhcardanian wants to merge 1 commit intoIntersectMBO:masterfrom
Minhcardanian wants to merge 1 commit intoIntersectMBO:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• # Description
I found that
cardano-nodeconfiguration parsing requiredDijkstraGenesisFilewheneverExperimentalHardForksEnabled = true, even though protocol instantiation already handled amissing Dijkstra config by falling back to the empty Dijkstra genesis.
That made some experimental configurations fail at parse/startup time even though the runtime path already supported the absence of a Dijkstra genesis file.
In this PR I make
DijkstraGenesisFileoptional during config parsing so parse-time behavior matches the existing runtime fallback:DijkstraGenesisFileis present, it is parsed and used as beforeNothingI reproduced the issue in the
10.7.0worktree before making the fix, then verified the fix with:cardano-node/test/Test/Cardano/Node/POM.hscardano-testnetgolden default config verificationcardano-testnetdump/load integration verificationValidation used:
nix develop . -c cabal test cardano-node-testnix develop . -c cabal test cardano-testnet-golden --test-options '-p "Golden tests.golden_DefaultConfig"'nix develop . -c cabal test cardano-testnet-test --test-options '-p dumping'Checklist
See Running tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-9.6andghc-9.12