cardano-testnet: Split testnet options into purpose-specific types#6552
Draft
cardano-testnet: Split testnet options into purpose-specific types#6552
Conversation
…e dummy flags and variables
8d63e40 to
28e37a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Split the monolithic
CardanoTestnetOptionsrecord into purpose-specific types so that:--node-envand--num-pool-nodesare structurally mutually exclusive in the CLI parser (via<|>, not optional fields that silently coexist).create-env), create-and-run (cardano), and run-from-existing-env (cardano --node-env).New type structure
TestnetCreationOptions— everything needed to create a testnet environment: nodes, era, max supply, num DReps, genesis options, on-chain params. Has aDefaultinstance for tests.TestnetRuntimeOptions— everything needed to run nodes: epoch state logging, gRPC, KES source. Has aDefaultinstance for tests.TestnetEnvOptions—--node-envpath + timestamp update policy.CardanoTestnetCliOptions— sum type:StartFromScratch StartFromScratchOptions | StartFromEnv StartFromEnvOptions, making the two modes exclusive at the type level.Checklist
See Running tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-9.6andghc-9.12