Edgr/sig submission v2 #16
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verify that `Sig` encoding produces a valid CBOR.
`SigSubmissionV2` protocol based on `ObjectDiffusion` from Peras. The client requests signatures while the server provides them (dual to `TxSubmission`). The patch provides: * protocol definition and GADT wrappers * CBOR codec * cddl specification checked against the codec * codec provides valid CBOR encoding (checked as a regular QC test rather than with the `cddl` tool)
coot
reviewed
Jan 15, 2026
coot
reviewed
Jan 15, 2026
Comment on lines
+1
to
+10
| {-# LANGUAGE BangPatterns #-} | ||
| {-# LANGUAGE BlockArguments #-} | ||
| {-# LANGUAGE DerivingVia #-} | ||
| {-# LANGUAGE LambdaCase #-} | ||
| {-# LANGUAGE NamedFieldPuns #-} | ||
| {-# LANGUAGE ScopedTypeVariables #-} | ||
| {-# LANGUAGE TupleSections #-} | ||
| {-# OPTIONS_GHC -Wno-unrecognised-pragmas #-} | ||
|
|
||
| module DMQ.SigSubmission.Inbound.Decision |
Contributor
There was a problem hiding this comment.
Why can't we re-use the original decision logic?
Member
Author
There was a problem hiding this comment.
I had intended to reuse the original decision logic, but a type change required me to duplicate the entire implementation.
coot
reviewed
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
Closes #13
Checklist