Migrate the union level once the merging tree is completed#838
Draft
mheinzel wants to merge 1 commit intomheinzel/golden-trace-messagesfrom
Draft
Migrate the union level once the merging tree is completed#838mheinzel wants to merge 1 commit intomheinzel/golden-trace-messagesfrom
mheinzel wants to merge 1 commit intomheinzel/golden-trace-messagesfrom
Conversation
mheinzel
force-pushed
the
mheinzel/empty-levels
branch
2 times, most recently
from
b9a6cd0 to
1246b46
Compare
mheinzel
force-pushed
the
mheinzel/migrate-union-level
branch
from
724b0d2 to
4012c33
Compare
mheinzel
force-pushed
the
mheinzel/golden-trace-messages
branch
from
ede9f1a to
258458e
Compare
mheinzel
force-pushed
the
mheinzel/migrate-union-level
branch
from
4012c33 to
6dd7c12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building on top of
#834#840, which we should merge first.Applies the idea outlined in #824 to the real implementation. Before merging, I still want to add tests,
update the probably broken doc test output forand do some cleanup.remainingUnionDebt,