Draft
Conversation
20 tasks
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See #1444
TxHashidentifies a transaction uniquely up to its contents (aux, witnesses etc). That's what makes it different toTxIdwhich identifies a transaction up to its ledger effect (in Ledger that means the sameTxBodyand in Plutus that means the sameTxInfo).See prop_tx_id_valid_effect_is_same and prop_tx_hash_effect_is_same for their exact properties and how they differ.
In a nutshell, we anticipate we might want to diffuse transactions identified via
TxHashfor Leios as we want to make sure only the validated transactions are diffused. SinceTxIdobtained from node-A and node-B can have a different witness set and one might fail while the other doesn't.DONE
GenTxHashfollowing the same pattern asGenTxIdand wire the types and concrete implementationsMempoolSnapshotandLedgerSupportsMempool