option for setting html into preview#205
Open
cornerman wants to merge 1 commit into
Open
Conversation
Ionaru
requested changes
Jul 9, 2020
Ionaru
left a comment
Ionaru
left a comment
Owner
There was a problem hiding this comment.
This would need some documentation on the new option setPreviewRender
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an option to set the preview html. Currently, we use
preview.innerHTML = htmlwhich is still the default. Now we allow users to render the html differently into the dom.My use-case is that setting
innerHTMLleads to flickering when an image is inside the preview. This way, I can now usehtml-to-reactfor the generated html and then render with react - which does the diffing for me. Maybe not a perfect solution, but for me this works much better now.