Skip to content

Added extractYaml option - #494

Open
faisalraja wants to merge 2 commits into
Ionaru:masterfrom
faisalraja:master
Open

Added extractYaml option#494
faisalraja wants to merge 2 commits into
Ionaru:masterfrom
faisalraja:master

Conversation

@faisalraja

Copy link
Copy Markdown

Handles yaml in front of markdown.

@faisalraja faisalraja mentioned this pull request Aug 24, 2022
@Ionaru

Ionaru commented Aug 30, 2022

Copy link
Copy Markdown
Owner

Can you add the new extractYaml option to easymde.d.ts?

@faisalraja

Copy link
Copy Markdown
Author

@Ionaru can you check issue #371
I have a question there, basically maybe it should always just be yaml-frontmatter and when extractYaml is provided, then it's going to remove it from preview? Right now it's also using extractYaml to decide if we'll use yaml-frontmatter.

@Ionaru

Ionaru commented Aug 31, 2022

Copy link
Copy Markdown
Owner

I think maybe we need to go a step further and always remove the yaml-frontmatter from the preview? Regardless of any option. I don't think there's any situation where you want to see it.

Then a extractYaml function can do something with the data if it wants, otherwise it's just sent as-is to the server.

@faisalraja

Copy link
Copy Markdown
Author

@Ionaru Makes sense. Updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants