Hotfix: Patching Overlay Mode#603
Open
peter-power-594 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greetings @Ionaru
This feedback is about a bug fix I guess.
I'm not a rock star with CodeMirror combined modes and tokens stuff so my patch might not be relevant at all - in this case sorry in advance 😝- from what I understand with the the current options, the custom
overlay-modeis overwritten by thespell-checkermode - so disabled actually 😅- if the spell checker is set to true.It's about an if / else snippet so there are various ways to patch it... And damage other setups if not done properly 💦
This patch works for me. Feel free to check and play with the demo page. 😉
Best regards,
Peter