[issue86] add rating to books#87
Open
RawandDev wants to merge 37 commits into
Open
Conversation
…ct-libvery into dev
…ct-libvery into dev
…ct-libvery into dev
…ct-libvery into dev
…ct-libvery into dev
…ct-libvery into dev
…ct-libvery into dev
…ct-libvery into dev
…ct-libvery into dev
…ct-libvery into dev
…ct-libvery into dev
…ct-libvery into dev
…ct-libvery into dev
…ct-libvery into dev
…ct-libvery into dev
…ct-libvery into dev
…ct-libvery into dev
…ct-libvery into dev
…ct-libvery into dev
…ct-libvery into dev
…ct-libvery into dev
…ct-libvery into dev
…ct-libvery into dev
…ct-libvery into dev
…ct-libvery into dev
…ct-libvery into dev
…ct-libvery into dev
…ct-libvery into dev
…ct-libvery into dev
…ct-libvery into dev
…ct-libvery into dev
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/libvery/capstone-react-libvery/8vmQcJu72bXeEnriPrCxjhL4jxCW |
| isHalf={true} | ||
| value={currentRating} | ||
| onChange={(newR) => setRating(newR)} | ||
| /> |
Member
There was a problem hiding this comment.
The user shouldn't be able to rate if he's not signed in, but he could see the rates only
Member
Author
There was a problem hiding this comment.
It is already implemented
| value={currentRating} | ||
| onChange={(newR) => setRating(newR)} | ||
| /> | ||
| <span className="pl-1 mt-1">{currentRating}(5)</span> |
Member
There was a problem hiding this comment.
No need to add this 👉🏼 "(5)", we already have just 5 stars so the user knows it's whatever/5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add rating to books. Sorry I didn't have much time to write the template.
https://gyazo.com/a259eb865a07226c926bc6894774ca42