Merged
Conversation
BobWall23
approved these changes
Jan 28, 2026
src/main/java/com/ironcorelabs/tenantsecurity/kms/v1/DeterministicCryptoUtils.java
Show resolved
Hide resolved
coltfred
requested changes
Jan 28, 2026
Member
coltfred
left a comment
coltfred
left a comment
There was a problem hiding this comment.
Thanks for fixing those oversights and making it easier to run all the tests. Just the one request.
src/main/java/com/ironcorelabs/tenantsecurity/kms/v1/BatchDocumentKeys.java
Outdated
Show resolved
Hide resolved
coltfred
approved these changes
Jan 29, 2026
Member
coltfred
left a comment
coltfred
left a comment
There was a problem hiding this comment.
Couple minor asks, but looks good beyond that.
| @@ -0,0 +1,6 @@ | |||
| package com.ironcorelabs.tenantsecurity.kms.v1; | |||
|
|
|||
| class VoidSecurityEventResponse extends NullParsingValidator { | |||
Member
There was a problem hiding this comment.
We should comment this class I think. At first I wasn't sure why we'd want this, so I definitely won't remember in the future.
Member
Author
There was a problem hiding this comment.
I ended up going a different way with it. I made an overload of makeRequestAndParseFailure for Void that doesn't do the parsing (and doesn't have the NullParsingValidator requirement). This let me delete the VoidSecurityEventResponse class altogether
src/main/java/com/ironcorelabs/tenantsecurity/kms/v1/WrappedDocumentKey.java
Outdated
Show resolved
Hide resolved
coltfred
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a potential issue when the TSP sends empty (or null) data back to the TSC. Instead of a NullPointerException it will now be returned as a regular TSC error.
Also fixes a few miscellaneous bugs along the way - incorrect construction of a DeterministicPlaintextField and several tests that didn't get updated for the new allowInsecureHttp flag. The CI was changed to run all the tests to ensure these don't slip through again.