Remove nullable annotations directives from Scripting#357
Merged
Conversation
slozier
approved these changes
May 6, 2026
Contributor
Agreed on this, been wanting to look into those for a while, but never find the time. I don't like the dependency on ironpython. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since all files in
Microsoft.Scriptingare annotated, it enables nullable annotations at the whole project level, rather than individually at the beginning of each file.Two generated files still have directive
#nullable enablebecause nullability project setting does not apply to generated files. But something has to be done with them:Perhaps best would be to use Roslyn code generators.
There are much more such cases in
Microsoft.Dynamic.