fix: update cmake config file and add find_package integration test#38
Merged
fix: update cmake config file and add find_package integration test#38
Conversation
After the Drogon decoupling refactoring, cpp-remote-profiler-config.cmake.in was still referencing the old `profiler_lib` target and finding PRIVATE deps (Backward, absl) that consumers don't need. This commit fixes the config file to match the new target structure (profiler_core/profiler_web) and adds a CI integration test to verify find_package correctness. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add cmake/examples/test_fetch_content/ to test add_subdirectory usage (simulates FetchContent consumption pattern) - Fix clang-format issue in test_find_package/main.cpp (include order) - Add add_subdirectory integration test step to GCC CI job - Document discovered issue: profiler_version.h include path broken with add_subdirectory due to global include_directories() usage Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Delete cmake/examples/{CMakeLists.txt,FetchContent_example.cmake,
FetchContent_integration_example.cpp} which used placeholder URLs
and deprecated singleton API (getInstance)
- Add FetchContent_Declare usage example as comments in
test_fetch_content/CMakeLists.txt so users can see both
add_subdirectory and FetchContent approaches in one place
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the Drogon decoupling refactoring, cpp-remote-profiler-config.cmake.in was still referencing the old
profiler_libtarget and finding PRIVATE deps (Backward, absl) that consumers don't need. This commit fixes the config file to match the new target structure (profiler_core/profiler_web) and adds a CI integration test to verify find_package correctness.