Conversation
The _guard (conn_span.enter()) and .instrument(conn_span) on the event loop were both entering the same span, producing duplicated conn:conn: prefix in log output. Fixed by dropping _guard before instrumenting the event loop. Assisted-by: OpenClaw:deepseek-v4-flash
Eliminate the dual span-entry pattern (_guard + .instrument) entirely. Now conn_span is never .enter()'d — it's only used via parent: for inline logs and .instrument() for spawned tasks and the event loop. This avoids the double-enter problem at the root and simplifies the code by removing _guard, clone, and 3x drop(_guard) calls. Assisted-by: OpenClaw:deepseek-v4-flash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The connection span was being entered twice — once via
_guard = conn_span.enter()and once viarun_tuic_event_loop().instrument(conn_span). This caused the compact log format to renderconn:conn:prefix instead of a singleconn{...}.Fix: drop
_guardbeforerun_tuic_event_loop().instrument(conn_span)in both the camouflage-detection and non-camouflage paths.