Skip to content

test: enhance controller drag click suppression test #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
IvanCCO wants to merge 1 commit into from
Closed

test: enhance controller drag click suppression test #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/content.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,9 @@

describe('controller drag suppresses the trailing click', () => {
it('does not toggle visibility when a click follows a drag', async () => {
let now = 1_000;
vi.spyOn(performance, 'now').mockImplementation(() => now);

await loadContentScript();
const overlay = getOverlay();
const controller = overlay.querySelector('.grid-ui__controller') as HTMLElement;
Expand All @@ -385,11 +388,19 @@
);
expect(overlay.classList.contains('grid-ui--dragging')).toBe(true);

controller.dispatchEvent(new PointerEvent('pointerup', { pointerId: 1 }));
controller.dispatchEvent(
new PointerEvent('pointerup', { pointerId: 1, clientX: 140, clientY: 100 }),
);
expect(overlay.classList.contains('grid-ui--dragging')).toBe(false);

now = 1_100;
axisTrigger.dispatchEvent(new MouseEvent('click', { bubbles: true, cancelable: true }));

expect(axisTrigger.dataset.state).toBe('visible');

Check failure on line 399 in src/content.test.ts

View workflow job for this annotation

GitHub Actions / validate

src/content.test.ts > controller drag suppresses the trailing click > does not toggle visibility when a click follows a drag 

AssertionError: expected 'hidden' to be 'visible' // Object.is equality

Expected: "visible"
Received: "hidden"

 ❯ src/content.test.ts:399:39

now = 1_500;
axisTrigger.dispatchEvent(new MouseEvent('click', { bubbles: true, cancelable: true }));

expect(axisTrigger.dataset.state).toBe('hidden');
});
});
Loading