test: update grid overlay rendering behavior based on enabled state#3
Merged
Conversation
- Modified tests to ensure the grid overlay does not render when disabled by default. - Updated the behavior to render the overlay when the enabled state is set to true. - Introduced a new function to merge session settings, improving the handling of grid settings based on site state. - Adjusted default settings to set 'enabled' to false, aligning with the new behavior. These changes enhance the clarity of the grid's visibility logic and ensure consistent behavior across different states.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes enhance the clarity of the grid's visibility logic and ensure consistent behavior across different states.
Summary by cubic
Grid overlay is now off by default and only renders when
enabled: true. Session UI state is merged into patterns to keep visibility and toolbar position consistent; tests updated to reflect the new behavior.Refactors
mergeSessionSettingsto apply session fields (enabled,visible,toolbarX,toolbarY) to pattern settings.getActivePattern,ensureAxisPattern,updateActivePatternSettings, andapplyPatternSelectionto preserve session state instead of resetting it.Migration
enabled: truewhen you want the overlay rendered (e.g., in tests or when sending settings messages).Written for commit a4ffd32. Summary will update on new commits.