Skip to content

test: update grid overlay rendering behavior based on enabled state#3

Merged
IvanCCO merged 1 commit into
mainfrom
turn-off-by-default
Jul 4, 2026
Merged

test: update grid overlay rendering behavior based on enabled state#3
IvanCCO merged 1 commit into
mainfrom
turn-off-by-default

Conversation

@IvanCCO

@IvanCCO IvanCCO commented Jul 4, 2026

Copy link
Copy Markdown
Owner
  • Modified tests to ensure the grid overlay does not render when disabled by default.
  • Updated the behavior to render the overlay when the enabled state is set to true.
  • Introduced a new function to merge session settings, improving the handling of grid settings based on site state.
  • Adjusted default settings to set 'enabled' to false, aligning with the new behavior.

These changes enhance the clarity of the grid's visibility logic and ensure consistent behavior across different states.


Summary by cubic

Grid overlay is now off by default and only renders when enabled: true. Session UI state is merged into patterns to keep visibility and toolbar position consistent; tests updated to reflect the new behavior.

  • Refactors

    • Added mergeSessionSettings to apply session fields (enabled, visible, toolbarX, toolbarY) to pattern settings.
    • Updated getActivePattern, ensureAxisPattern, updateActivePatternSettings, and applyPatternSelection to preserve session state instead of resetting it.
  • Migration

    • Explicitly set enabled: true when you want the overlay rendered (e.g., in tests or when sending settings messages).

Written for commit a4ffd32. Summary will update on new commits.

Review in cubic

- Modified tests to ensure the grid overlay does not render when disabled by default.
- Updated the behavior to render the overlay when the enabled state is set to true.
- Introduced a new function to merge session settings, improving the handling of grid settings based on site state.
- Adjusted default settings to set 'enabled' to false, aligning with the new behavior.

These changes enhance the clarity of the grid's visibility logic and ensure consistent behavior across different states.
@IvanCCO
IvanCCO merged commit 6f2319f into main Jul 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant