Image loading tests stability improvement#44
Merged
Merged
Conversation
…t Store Tools package. Update package.json to reference the GitHub repository directly. Add new project settings files for memory and version control configurations. Update ProjectVersion.txt to reflect the new Unity editor version. Clean up unnecessary files and ensure proper package management.
Introduces IWebRequestProvider interface to enable dependency injection of web requests, allowing for mock implementations during testing. Updates FutureSprite and FutureTexture to use the new provider pattern. Adds MockWebRequest and MockWebRequestProvider for comprehensive testing without network calls. Includes test utilities for mock response configuration and adds CLAUDE.md documentation. Also updates to Unity 2022.3 and adds MCP integration dependencies.
# Conflicts: # Installer/Packages/com.unity.asset-store-tools/Editor/Api/Abstractions/IAssetStoreClient.cs.meta # Installer/Packages/com.unity.asset-store-tools/Editor/Api/Abstractions/IAuthenticationType.cs.meta # Installer/Packages/packages-lock.json # README.md # Unity-Package/Assets/Resources.meta # Unity-Package/Assets/Resources/Unity-MCP-ConnectionConfig.json.meta # Unity-Package/Assets/root/README.md # Unity-Package/Assets/root/Tests/Base/Utils/MockWebRequest.cs.meta # Unity-Package/Assets/root/Tests/Base/Utils/MockWebRequestProvider.cs # Unity-Package/Assets/root/Tests/Base/Utils/MockWebRequestProvider.cs.meta # Unity-Package/Assets/root/Tests/Base/Utils/TestHttpServer.cs.meta # Unity-Package/Assets/root/Tests/Base/Utils/TestUtils.cs
…oject The Unity-Package project manifest had accidentally picked up com.ivanmurzak.unity.mcp (0.17.2) and com.unity.ai.navigation (1.1.5) plus the whole MCP NuGet/SignalR scoped-registry chain. Neither is a dependency of the Image Loader library, and both fail to compile on the older editors in the test matrix: - com.unity.ai.navigation@1.1.5: CS1061 NavMeshSurface.IsPartOfPrefab - com.ivanmurzak.unity.mcp@0.17.2: CS0246 EnumField / IntegerField "Scripts have compiler errors" made Unity exit before running any test, so every 2019/2020/2021/2022 job failed at compilation (2023.1+ passed because the newer API exists there). Restore Packages/manifest.json, packages-lock.json and PackageManagerSettings.asset to main's known-good clean state. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Unity version used for building and testing the installer, adds recommended VS Code settings for Unity development, and removes the Asset Store Tools API source code from the repository. The main changes are grouped below:
Build and CI Updates:
2019.4.40f1to2021.3.45f1in both.github/workflows/release.ymland.github/workflows/test_pull_request.yml, ensuring compatibility with newer Unity features and packages. [1] [2]Developer Environment Improvements:
Installer/.vscode/, including recommended extensions and an "Attach to Unity" debug configuration. [1] [2]Installer/.vscode/settings.jsonto improve file exclusions and specify the default solution file for .NET development. [1] [2]Asset Store Tools Package Cleanup:
Installer/Packages/com.unity.asset-store-tools/Editor/Api/Abstractions/, as well as theCHANGELOG.mdand several.metafiles, likely in preparation for using the package as a prebuilt dependency rather than maintaining source. [1] [2] [3] [4] [5] [6] [7] [8]These changes modernize the build environment, streamline developer setup, and simplify package maintenance by removing bundled source code for third-party tools.