Fix: Allow upgrades with hidden fields#7
Fix: Allow upgrades with hidden fields#7google-labs-jules[bot] wants to merge 1 commit intotemplate-upgrade-propertiesfrom
Conversation
This commit resolves an issue where the upgrade button in the resource upgrade dialog was incorrectly disabled when a form contained hidden fields that were not filled out by the user. The previous validation logic naively checked for any empty or undefined values, which failed to account for hidden or non-required fields. This has been replaced with a new `checkFormValidity` function that uses the `rjsf` (React JSON Schema Form) validator to validate the form data against the JSON schema. This ensures that only fields explicitly marked as `required` in the schema are validated, and hidden, optional fields no longer prevent the form from being considered valid.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
This commit fixes an issue where the upgrade button was disabled if a conditionally hidden field was not filled in. The validation logic was updated to use a proper schema validator, which correctly handles hidden fields.
PR created automatically by Jules for task 12891976559331246792 started by @JC-wk