Skip to content

Bug fix in repos/spack_repo/builtin/packages/netcdf_c/package.py to find MPI functions when build system is cmake #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
climbfuji wants to merge 3 commits into from
Closed

Bug fix in repos/spack_repo/builtin/packages/netcdf_c/package.py to find MPI functions when build system is cmake #18

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
551b80b
Bug fix in repos/spack_repo/builtin/packages/netcdf_c/package.py to f…
climbfuji Nov 6, 2025
539d57a
Merge branch 'spack-stack-dev' into bugfix/netcdf_c_cmake_mpi_spack_s…
climbfuji Nov 11, 2025
e135cac
For netcdf-c, apply cmake patches only of build_system=cmake
climbfuji Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions repos/spack_repo/builtin/packages/netcdf_c/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,7 @@ class NetcdfC(CMakePackage, AutotoolsPackage):

build_system("cmake", "autotools", default=default_build_system)

@when("build_system=cmake")
def patch(self):
"""Fix bad code in ncgen/CMakeLists.txt that removes
the rpath for dependencies like hdf5."""
Expand All @@ -297,6 +298,16 @@ def patch(self):
"ncgen/CMakeLists.txt",
string=True
)
# https://github.com/Unidata/netcdf-c/issues/3199
filter_file(
"CHECK_FUNCTION_EXISTS(MPI_Comm_f2c HAVE_MPI_COMM_F2C)",
"""if(MPI_mpi_LIBRARY)
SET(CMAKE_REQUIRED_LIBRARIES ${MPI_mpi_LIBRARY} ${CMAKE_REQUIRED_LIBRARIES})
endif()
CHECK_FUNCTION_EXISTS(MPI_Comm_f2c HAVE_MPI_COMM_F2C)""",
"CMakeLists.txt",
string = True
)

def setup_run_environment(self, env: EnvironmentModifications) -> None:
if self.spec.satisfies("@4.9.0:+shared"):
Expand Down