Smart#176
Merged
Merged
Conversation
…consistency and update menu in load
JasmineRRod
requested review from
eSteemRoller,
jamesmarkchan,
jslcom and
tylermlui
15 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Adds initial Linux SMART (smartctl JSON) support with snapshot persistence/replay, and restructures the UI to introduce a left-side main navigation (Drives / Benchmark / SMART) plus a SMART Reports table.
Changes:
- Introduces SMART data acquisition via a privileged
pkexec bashshell, SMART parsing, and GUI rendering in a dedicated SMART tab. - Adds persistent SMART snapshot storage (Derby/JPA) and a SMART Reports table for browsing/deleting/replaying snapshots.
- Adds a new Drives tab and reorganizes the main window layout using a left vertical tab pane and a vertical split-pane.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
| jdm-core/src/main/java/jdiskmark/Smart.java | SMART JSON parsing + privileged shell lifecycle + SMART querying |
| jdm-core/src/main/java/jdiskmark/SmartPanel.java | SMART tab UI rendering for NVMe/ATA health sections |
| jdm-core/src/main/java/jdiskmark/SmartSnapshot.java | JPA entity + snapshot save/load/delete APIs (incl raw JSON replay) |
| jdm-core/src/main/java/jdiskmark/SmartReportsPanel.java | Snapshot list UI with selection-to-replay and delete actions |
| jdm-core/src/main/java/jdiskmark/Gui.java | SMART tab refresh, snapshot load, snapshot save wiring |
| jdm-core/src/main/java/jdiskmark/MainFrame.java | UI restructuring: left main navigation tabs + SMART integration |
| jdm-core/src/main/java/jdiskmark/DrivesPanel.java | New Drives tab for selecting benchmark target and test directory |
| jdm-core/src/main/java/jdiskmark/BenchmarkRunner.java | Optional pre-benchmark SMART fetch (Linux) |
| jdm-core/src/main/java/jdiskmark/App.java | Persisted smartEnable config toggle |
| jdm-core/src/main/java/jdiskmark/MainFrame.form | Adds SMART checkbox menu item to Options menu |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add prepare-smartctl.yml workflow to JDiskMark/jdm-deps to build
smartctl 7.5 from source (ubuntu:22.04, glibc 2.35 target) and
publish as a GitHub Release asset
- linux-deb.yml: fetch smartctl from jdm-deps before Maven build;
extend smoke test to verify binary is present and runs
- jdm-deb/pom.xml: inject smartctl/ dir and polkit policy file into
the DEB during the existing repack step (dpkg-deb -R/-b)
- template.postinst: install net.jdiskmark.smartctl.policy to
/usr/share/polkit-1/actions/ for branded pkexec prompt
- Smart.java: resolveSmartctlPath() prefers bundled binary at
\$APPDIR/../smartctl/smartctl with fallback to /usr/sbin/smartctl
--app-content is silently ignored by jpackage when building DEB packages
directly. Use the existing repack bash step (dpkg-deb -R/-b) to inject
smartctl/ and the polkit policy file into the unpacked image before
repacking. Also make the postinst polkit install non-fatal so headless
CI runners without polkit installed don't fail the package hook.
commit 7f6b4ef
Author: James Mark Chan <jamesmarkchan@gmail.com>
Date: Sat Jun 27 18:52:01 2026 -0700
| config.gcRetryEnabled = GcDetector.gcRetryEnabled; | ||
| config.gcHintsEnabled = GcDetector.gcHintsEnabled; | ||
| config.multiFileEnabled = multiFile; | ||
| // config.enabledSmart = Smart.smartEnable; --- TODO in config --- |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Still in to-do:
out of scope: