fix(web): redact malformed URL secrets in MCP validator#542
Conversation
|
Warning Review limit reached
More reviews will be available in 11 minutes and 59 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…-mcp-url-redaction-issue
Motivation
urlstrings or URL-likeargswere returned unchanged byredactUrlValue()and could leak recognizable secrets intoreportTextandfixedConfigText.Description
redactUrlValue()to fall back toredactEnvValue("url", value)whennew URL(value)throws so malformed URL-like values are still subject to generic secret-pattern redaction.redactedCountwhen the fallback actually redacts content.it("redacts malformed URL-like values that contain secrets")intests/mcp-config-validator.test.tsthat exercises a malformed top-levelurland a malformed URL-likeargsentry.Testing
pnpm exec vitest run tests/mcp-config-validator.test.tsand all tests passed (12 tests).git diff --checkto validate whitespace/formatting and it reported no issues.Codex Task