Skip to content

feat(miner-extension): add a standard icon set to the manifest#5617

Merged
JSONbored merged 1 commit into
JSONbored:mainfrom
davion-knight:feat-miner-extension-icons
Jul 13, 2026
Merged

feat(miner-extension): add a standard icon set to the manifest#5617
JSONbored merged 1 commit into
JSONbored:mainfrom
davion-knight:feat-miner-extension-icons

Conversation

@davion-knight

Copy link
Copy Markdown
Contributor

Adds a standard 16/32/48/128 PNG icon set to the miner extension (dark 'G' on the brand mint, matching the opportunity badge), wired into manifest.icons and the toolbar action.default_icon, and included in build-miner-extension.mjs's package list so the built extension ships every icon it references. Test asserts each declared icon exists as a real RGBA PNG at its declared size. Verified: icons test + tsc clean + build packages all 12 referenced files.

Fixes #4862

The extension manifest defined no icons. Add a 16/32/48/128 PNG icon set (a dark 'G'
mark on the extension's mint accent, matching the opportunity badge) wired into both
manifest.icons and the toolbar action's default_icon, and include them in the build
package's file list so the packaged extension ships every icon it references.

Fixes JSONbored#4862
@davion-knight davion-knight requested a review from JSONbored as a code owner July 13, 2026 10:09
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jul 13, 2026
@loopover-orb

loopover-orb Bot commented Jul 13, 2026

Copy link
Copy Markdown

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ LoopOver review result - manual review recommended

Review updated: 2026-07-13 10:22:48 UTC

7 files · 1 AI reviewer · no blockers · readiness 100/100 · CI green · clean

⏸️ Suggested Action - Manual Review

  • Touches a guarded path — held for manual review: This PR changes guardrail-protected path(s): scripts/build-miner-extension.mjs (matched scripts/**).

Review summary
This PR adds a 16/32/48/128 icon set to the miner extension's manifest.json and action.default_icon, includes the four PNGs in the build script's PACKAGE_FILES list, and adds mkdirSync(dirname(dest)) so nested paths like icons/ are created before copying. A dedicated test verifies each declared icon exists on disk, is a valid PNG signature, matches its declared dimensions, and is RGBA (colorType 6). This is a small, well-scoped, correctly-wired change that closes #4862, and CI (including the new test) passed on this exact commit.

Nits — 4 non-blocking
  • The four PNG icons are committed binary artifacts with no generation script or source (e.g. SVG) checked in, so future edits require regenerating them out-of-band — consider noting how they were produced in the PR description or a comment.
  • manifest.icons declares a 128px icon but action.default_icon stops at 48px (per Chrome MV3 convention this is fine, but a one-line comment noting why 128 is omitted from the toolbar icon would save a future reader from wondering).
  • Consider adding a short README note or generation command for the icon set so contributors know how to regenerate them if the brand mint color changes.
  • Touches a guarded path — held for manual review — A maintainer must review and merge this change.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ Linked #4862
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 131 registered-repo PR(s), 94 merged, 2 issue(s).
Contributor context ✅ Confirmed Gittensor contributor davion-knight; Gittensor profile; 131 PR(s), 2 issue(s).
Gate result ⚠️ Not blocking Advisory; not blocking this PR.
Improvement ✅ Minor risk: clean · value: minor — Code changes are accompanied by test evidence.
Review context
  • Author: davion-knight
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Rust
  • Official Gittensor activity: 131 PR(s), 2 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Keep the PR focused and include validation evidence before maintainer review.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
[BETA] Chat with Gittensory

Ask Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @gittensory ask <question> answers contribution-quality Q&A with source citations and freshness.
  • @gittensory chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @gittensory mention with a real question is routed to the closest matching read-only command automatically -- no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands

Visual preview
Route Viewport Before (production) After (this PR's preview) Diff
/ desktop before / after /
/ mobile before / (mobile) after / (mobile)

Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot added the manual-review Gittensor contributor context label Jul 13, 2026
@JSONbored JSONbored merged commit 2e8fdd7 into JSONbored:main Jul 13, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. manual-review Gittensor contributor context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add icons to the extension manifest

2 participants