fix(release): target merge commits for aio tags#44
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 46727cf07d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "rev-list", "--first-parent", "--reverse", f"{release_commit}..HEAD" | ||
| ).splitlines() | ||
| if first_parent_path: | ||
| return first_parent_path[0] |
There was a problem hiding this comment.
When main has additional commits after the release branch was cut, rev-list --first-parent --reverse "${release_commit}..HEAD" yields all intervening first-parent commits and this code picks the first one, which is typically an older main commit rather than the merge commit that actually brought the release in. In that case Publish Release will validate CI and create the release tag/GitHub release against the wrong SHA (which may not contain the release changes).
Useful? React with 👍 / 👎.
| case "${changelog_version}" in | ||
| "${upstream_version}"-aio.*) | ||
| release_target="$(python3 scripts/release.py find-release-target-commit "${changelog_version}" 2>/dev/null || true)" | ||
| if [[ "${release_target}" == "${GITHUB_SHA}" || "${GITHUB_EVENT_NAME}" == "workflow_dispatch" ]]; then |
There was a problem hiding this comment.
This condition makes every workflow_dispatch run on main assign release_package_tag even when GITHUB_SHA is not the resolved release target commit. If someone manually reruns CI after newer commits land, the existing *-aio.N tag can be republished from non-release code, breaking release tag immutability and reproducibility for users pulling that version tag.
Useful? React with 👍 / 👎.
|
Superseded by #45, which fixes both release-target selection and manual-dispatch tag immutability with unit coverage. |
1 participant
Summary
What changed
Why
Validation
Notes