Skip to content

feat(registry): add SN62 Ridges public data artifact via TaoMarketCap#4911

Closed
dhgoal wants to merge 1 commit into
JSONbored:mainfrom
dhgoal:feat-registry-sn62-ridges-taomarketcap-artifact
Closed

feat(registry): add SN62 Ridges public data artifact via TaoMarketCap#4911
dhgoal wants to merge 1 commit into
JSONbored:mainfrom
dhgoal:feat-registry-sn62-ridges-taomarketcap-artifact

Conversation

@dhgoal

@dhgoal dhgoal commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Appends one data-artifact surface to registry/subnets/ridges.json (SN62, Ridges). Append-only — existing surfaces and top-level fields are unchanged.

Surface

The TaoMarketCap developer API exposes a public no-auth GET /public/v1/subnets/{netuid} snapshot returning machine-readable JSON for on-chain subnet state, SubnetIdentitiesV3 metadata, economics, and dTAO market fields — verified live for netuid 62. Registered as a standing subnet-state data artifact for SN62 (the same universal TaoMarketCap subnet feed already registered for other subnets).

Test plan

  • npm run surface:add — OK reachable + public-safe
  • npm run validate:surface -- registry/subnets/ridges.json — passed
  • npm run scan:public-safety -- registry/subnets/ridges.json — passed
  • Verified https://api.taomarketcap.com/public/v1/subnets/62 returns HTTP 200 with valid JSON (netuid: 62)
  • Confirmed no existing registry surface url uses this endpoint (avoids duplicate-surface rejection)

Closes #4069

Appends one data-artifact surface to registry/subnets/ridges.json (SN62,
Ridges). Append-only — existing surfaces and top-level fields unchanged.

The TaoMarketCap developer API exposes a public no-auth GET
/public/v1/subnets/{netuid} snapshot returning machine-readable JSON for
on-chain subnet state, SubnetIdentitiesV3 metadata, economics, and dTAO market
fields — verified live for netuid 62 (HTTP 200). Registered as a standing
subnet-state data artifact for SN62.

Closes JSONbored#4069
@dhgoal dhgoal requested a review from JSONbored as a code owner July 11, 2026 17:36
@superagent-security

Copy link
Copy Markdown

🚨 Contributor flagged. Click here for more info: Superagent Dashboard

@superagent-security superagent-security Bot added the contributor:flagged Contributor flagged for review by trust analysis. label Jul 11, 2026
@superagent-security

Copy link
Copy Markdown

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.70%. Comparing base (e9f2383) to head (d594434).
⚠️ Report is 103 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4911   +/-   ##
=======================================
  Coverage   97.70%   97.70%           
=======================================
  Files         161      161           
  Lines       18553    18553           
  Branches     6921     6921           
=======================================
  Hits        18127    18127           
  Misses         59       59           
  Partials      367      367           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gittensory-orb gittensory-orb Bot added gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. gittensor:priority Maintainer-selected Gittensor priority — scores a 1.5x multiplier. Reserved for outstanding work. labels Jul 11, 2026
@gittensory-orb

gittensory-orb Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Caution

🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥

🛑 Gittensory review result - reject/close recommended

Review updated: 2026-07-11 17:43:09 UTC

1 file · 2 AI reviewers · 2 blockers · readiness 100/100 · CI green · unstable

🛑 Suggested Action - Reject/Close

  • A surface submission must not duplicate an entry already in this PR or already in the registry — resubmit without the duplicate.

Review summary
Append-only data-artifact addition to registry/subnets/ridges.json for SN62, registering the TaoMarketCap universal subnet-state feed at /public/v1/subnets/62. Diff is single-file, netuid matches (62), existing surfaces and top-level fields are preserved (only whitespace/key-reordering churn elsewhere), and the new surface correctly uses authority: community and review.state: community-submitted. However, this is the same TaoMarketCap universal feed pattern seen in sibling manifests (e.g. bitads.json), and source_repo/website fields for Ridges are already machine-promoted from on-chain identity — the new surface itself (dashboard_url already links taomarketcap.com/subnets/62) adds a callable data-artifact that is plausibly non-redundant with existing surfaces, but the PR's own claim that this indexed feed is not redundant with the already-registered dashboard_url should be checked against the review's redundancy rubric.

Blockers

  • registry/subnets/ridges.json:1 rewrites the existing manifest ordering instead of appending only the new surface to `surfaces[]`; for an existing-manifest data PR, restore the original top-level and existing-surface ordering and leave only the new `sn-62-taomarketcap-data-artifact` object as the semantic diff.
Nits — 6 non-blocking
  • The external brief's 'hardcoded service URL' flags are boilerplate IaC noise, not real config issues, since registry surface URLs are the entire point of this data file.
  • Confirm the linked issue Enrich SN62 Ridges — add public data artifact #4069 fully scopes this exact TaoMarketCap artifact (brief notes only 'partial' coverage) rather than a different SN62 surface.
  • Whole-file key reordering (alphabetization) in the diff is unrelated churn that makes the diff harder to review even though the JSON content is unchanged.
  • Verify the live https:​//api.taomarketcap.com/public/v1/subnets/62 endpoint body actually returns netuid: 62 and Ridges-specific fields as claimed in the test plan, since this cannot be confirmed from the diff alone.
  • Double check no other Ridges surface (e.g. dashboard_url) already exposes equivalent on-chain subnet-state data that would make this addition redundant.
  • Diff looks like trivial or whitespace-only churn — Reduce whitespace-only or formatting-only churn and keep the diff focused on substantive changes.

Why this is blocked

  • registry/subnets/ridges.json:1 rewrites the existing manifest ordering instead of appending only the new surface to `surfaces[]`; for an existing-manifest data PR, restore the original top-level and existing-surface ordering and leave only the new `sn-62-taomarketcap-data-artifact` object as the semantic diff.
  • Registry surface review
Flagged checks (non-blocking)
  • Contributor trust — Contributor flagged for review
Signal Result Evidence
Code review ❌ 2 blockers 2 reviewers, synthesized
Linked issue ✅ Linked #4069
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 101 registered-repo PR(s), 62 merged, 14 issue(s).
Contributor context ✅ Confirmed Gittensor contributor dhgoal; Gittensor profile; 101 PR(s), 14 issue(s).
Gate result ❌ Blocking Repo-configured hard blocker found.
Linked issue satisfaction

Addressed
The PR appends exactly one new data-artifact surface to registry/subnets/ridges.json pointing to TaoMarketCap's public no-auth JSON endpoint for netuid 62, with source_urls proving the official developer docs and matching provider slug, satisfying the issue's ask for a real, verifiable public data artifact.

Review context
  • Author: dhgoal
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: not available
  • Official Gittensor activity: 101 PR(s), 14 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Keep the PR focused and include validation evidence before maintainer review.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
[BETA] Chat with Gittensory

Ask Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @gittensory ask <question> answers contribution-quality Q&A with source citations and freshness.
  • @gittensory chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @gittensory mention with a real question is routed to the closest matching read-only command automatically -- no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@gittensory-orb

Copy link
Copy Markdown
Contributor

Gittensory is closing this pull request on the maintainer's behalf (AI reviewers agree on a likely critical defect: registry/subnets/ridges.json:1 rewrites the existing manifest ordering instead of appending only the new surface to `surfaces[]`; for an existing-manifest data PR, restore the original top-level and existing-surface ordering and leave only the new `sn-62-taomarketcap-data-artifact` object as the semantic diff.; Registry surface review). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed.

@gittensory-orb gittensory-orb Bot closed this Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor:flagged Contributor flagged for review by trust analysis. gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. gittensor:priority Maintainer-selected Gittensor priority — scores a 1.5x multiplier. Reserved for outstanding work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enrich SN62 Ridges — add public data artifact

1 participant