feat(ui): add focus-visible ring styling to ProfileTabs and EndpointKindTabs buttons#4914
feat(ui): add focus-visible ring styling to ProfileTabs and EndpointKindTabs buttons#4914dhgoal wants to merge 1 commit into
Conversation
…indTabs buttons Both tab strips built their button className via classNames(...) with no focus-visible/outline classes, so keyboard-focused tabs fell back to the raw default browser outline — the two outliers versus the rest of the app, which applies the existing .mg-focus-ring utility (styles.css, used by mg-metric-tile, hero-subnet-chips, ...). Wire that same utility onto both tab buttons so a keyboard-focused tab shows the design-system ring and no ring on mouse click (:focus-visible). No new CSS, no markup restructuring, no change to hover/active/selected styling. Closes JSONbored#3451
|
🚨 Contributor flagged. Click here for more info: Superagent Dashboard |
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-11 19:44:55 UTC
⏸️ Suggested Action - Manual Review
Review summary Nits — 6 non-blocking
Flagged checks (non-blocking)
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
[BETA] Chat with GittensoryAsk Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands Visual preview
Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
What & why
ProfileTabsandEndpointKindTabsbuilt their tab<button>className viaclassNames(...)with no focus-visible/outline classes, so keyboard-focused tabs fell back to the raw default browser outline — the two outliers versus the rest of the app, which applies the existing.mg-focus-ringutility (styles.css, already used bymg-metric-tile,hero-subnet-chips, …).This wires that same existing utility onto both tab buttons: a keyboard-focused tab shows the design-system ring; a mouse click shows no ring (
:focus-visible)..mg-focus-ringalready exists), no markup restructuring, no change to hover/active/selected styling.+mg-focus-ringon the two tab buttons (+2 / -2).Before / after — keyboard-focused tab (all viewports × themes)
ProfileTabs — subnet detail (
/subnets/{netuid})EndpointKindTabs — endpoints page (
/endpoints)The focused (3rd) tab is shown in each pair. Delta: raw default browser outline → the rounded
.mg-focus-ringmatching the rest of the app.Closes #3451